Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Road to version 9.0: Updated go version to 1.22 & Fixed Breaking Changes ✨ #1037

Open
wants to merge 32 commits into
base: version-9.0
Choose a base branch
from
Open

[WIP] Road to version 9.0: Updated go version to 1.22 & Fixed Breaking Changes ✨ #1037

wants to merge 32 commits into from

Conversation

ansh-devs
Copy link

@ansh-devs ansh-devs commented Jul 22, 2024 •
edited
Loading

Changes

  • Updated GO version to 1.22.
  • Updated deprecated WebhookServer And CacheNamespace configurations to use the updated controller-runtime.
  • Refactored configMapResource in jenkinsController.
  • Makefile Indentation fixed.
  • Nix Builds unresolved dependencies fixed. (Now checks are successfully passing).
  • Updated golangci-lint version to [email protected].
  • Updated Mocks for pkg/controller/jenkins/client/jenkins.go to support new changes.
  • Update E2E tests and make them compatible with new changes.

Pending changes

  • Update HELM tests and make them compatible with new changes.

NOTE

  • As of now only one change has been made in .github/workflows that is to exclude go.sum from Codespell

View Patch

brokenpip3 and others added 23 commits July 19, 2024 15:14
@brokenpip3
fix handler.go
0f80a5f
@ansh-devs
refactor: minor fixes
b7f4e25
@ansh-devs
fix: manager for controller
bfd9d3c
@ansh-devs
fix: deprecated Webhook Server & cache Namespace
9cfc490
@ansh-devs
chore: tidy go.mod
b86f06d
@ansh-devs
chore: Makefile indentation
141df91
@ansh-devs
update golangci-lint version
0091907
@ansh-devs
chore: added sort-result in golangci
0ea755e
@ansh-devs
chore: dependencies update
1851026
@ansh-devs
chore: resmap dependency added
cf6f304
@ansh-devs
chore: tidy go.mod
23dc235
@ansh-devs
chore: linter resource package dependency added
62d43f9
@ansh-devs
fix: restorebackup test migrated to use VolumeResourceRequirements
9ba4586
@ansh-devs
deps: golangci dependency modified
62a1e7c
@ansh-devs
fix: refactored to support context API
9d12e54 
- Context API support is added to the Jenkins API interface.
@ansh-devs
feat: mocks updated
87ec9f8 
- Old mocks removed
- New Mocks Added for Jenkins API that has support for context API
@ansh-devs
fix: golangci linting errors
b2f6f48
@ansh-devs
fix(ci)- fixed golangci linting errors
1cb7be2
@ansh-devs
fix: tests, golangci
404c5e0 
*Changes*

- Continuation WIP of  jenkinsci#954
- Updated Go Version to - v1.22
- Updated Mocks for `pkg/controller/jenkins/client/jenkins.go` to support new changes
- Updated package level tests
- refactored code to adapt `context` API
- Updated dependencies

*Pending*

- [] make E2E & HELM tests compatible to new changes
@ansh-devs
chore: updated go version in nix
dee9bbf
@ansh-devs
chore(deps): updated go version in base.env
c4d583e
@ansh-devs
(chore): updated node version in nix configs
df66c98
@ansh-devs
refactor(tests): reconcile_test
dd31159
@ansh-devs ansh-devs mentioned this pull request Jul 22, 2024
Draft
@brokenpip3
Copy link
Collaborator

wow great work in few days so far! 👏 🚀

let's remove the prealloc linter from the golanci-lint config temporary so we can see what is the status of the e2e tests :)

Checking the bats logs I saw some issues but let's make sure that the e2e tests are working first, I can help in case of issues since I have the deep knowledge of those tests, so let me know in case you will face something odd :)

@ansh-devs
Copy link
Author

ansh-devs commented Jul 23, 2024 •
edited
Loading

Sure, Iet's go with that

@brokenpip3
Copy link
Collaborator

I see great progress :)

to fix the latest issues can you update the controller gen version?
Taking a quick look should be something like:

-KUSTOMIZE_VERSION ?= v3.8.7
-CONTROLLER_TOOLS_VERSION ?= v0.9.2
+KUSTOMIZE_VERSION ?= v5.3.0
+CONTROLLER_TOOLS_VERSION ?= v0.14.0

we probably also need to change the envtest version and installation method but it's not critical now

@ansh-devs
Copy link
Author

I see great progress :)

to fix the latest issues can you update the controller gen version? Taking a quick look should be something like:

-KUSTOMIZE_VERSION ?= v3.8.7
-CONTROLLER_TOOLS_VERSION ?= v0.9.2
+KUSTOMIZE_VERSION ?= v5.3.0
+CONTROLLER_TOOLS_VERSION ?= v0.14.0

we probably also need to change the envtest version and installation method but it's not critical now

seems to be an type check errors issue among packages I will look into it !

@ansh-devs
Copy link
Author

@brokenpip3 Have you checked it

@brokenpip3
Copy link
Collaborator

ehi @ansh-devs unfortunately no, I still need to do it.
I usually try to cover one or two weekends to work on oss projects but so far I was not able to do it, 'cause life.
I will try to do my best in the following weeks, don't worry, soon or later I will put the proper effort like I did in the past 2 years :)
I'm sorry if your PRs is blocked by me but right now I can't do more than this.

@ansh-devs
Copy link
Author

Sure take your time😃

@ansh-devs
Copy link
Author

Hi @brokenpip3, are there any breaking changes due to upgrade ?

@brokenpip3
Copy link
Collaborator

No no nothing :)
I was just bumping to exclude other issues for the tests, I'm positive that soon I will have one day to dedicate to find the failures and unblock this PR and the migration epic :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ansh-devs ansh-devs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ansh-devs @brokenpip3